Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respacing DV YML #16

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Mar 19, 2024

Description

Title.

TODO

Quite a lot.

Part 1

Part 2

  • Reorder every .yml alphabetically
  • Clean up parentage & inheritance
  • Uncomment every Delta-V uncomment.

I stuck the Crime Assist cartridge in it's own folder to package it together with the "flow", which is the pages just .ymled
This also includes some TODO's for a future PR I need to make
TODO: Should look more at PDA.yml
TODO: LOOK THROUGH THE COMMENTS IN SECURITY.YML
TODO: WORTH LOOKING THROUGH THE COMMENTS
@DangerRevolution DangerRevolution changed the title Moving .yml from Delta --> EE Folders Moving / Merging .yml from Delta --> EE Folders Mar 19, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Moving / Merging .yml from Delta --> EE Folders Respacing DV YAML Mar 19, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 2-Large For large issues/PRs Priority: 1-Urgent Must be resolved immediately Type: Respace Moving something from an old namespace labels Mar 19, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Respacing DV YAML Respacing DV YML Mar 19, 2024
@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Mar 19, 2024
@github-actions github-actions bot added the Changes: Config Changes any configuration files label Mar 19, 2024
@stellar-novas stellar-novas force-pushed the Porting-Things-Part-1 branch from ab2487b to 7a6c7d7 Compare March 19, 2024 21:46
@github-actions github-actions bot added Changes: Map Changes any yml file in the Maps directories and removed Changes: YML Changes any yml files labels Mar 20, 2024
@stellar-novas stellar-novas force-pushed the Porting-Things-Part-1 branch from 087e68b to cc454b3 Compare March 20, 2024 04:20
@DangerRevolution DangerRevolution marked this pull request as ready for review March 20, 2024 10:54
@DangerRevolution DangerRevolution marked this pull request as draft March 20, 2024 21:20
@DangerRevolution DangerRevolution marked this pull request as ready for review March 21, 2024 19:08
@DangerRevolution DangerRevolution marked this pull request as draft March 23, 2024 22:49
@DangerRevolution DangerRevolution marked this pull request as ready for review March 27, 2024 20:31
@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Mar 30, 2024
@VMSolidus
Copy link
Member

I'm closing this as per a notice for our new policy regarding code respacing. As stated on our discord at this link:
https://discord.com/channels/1218698320155906090/1218698321053356059/1224795186689867818

@VMSolidus VMSolidus closed this Apr 2, 2024
dasprino007 pushed a commit to dasprino007/Einstein-Engines that referenced this pull request Jul 20, 2024
Update SpaceWindMinimumCalculatedMass to tweak things
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
gluesniffler pushed a commit to gluesniffler/Einstein-Engines that referenced this pull request Oct 13, 2024
Surgery condition rework + guidebook entry
gluesniffler added a commit to gluesniffler/Einstein-Engines that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Config Changes any configuration files Changes: Localization Changes any ftl files Changes: Map Changes any yml file in the Maps directories Changes: Sprite Changes any png or json in an RSI Priority: 1-Urgent Must be resolved immediately Size: 2-Large For large issues/PRs Type: Respace Moving something from an old namespace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants